Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update vertex edm to 4d quantities #61

Merged
merged 9 commits into from
Feb 2, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions edm4eic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ components:
return covariance[i + 1 + (j + 1) * (j) / 2 - 1];\n
}\n
"

wdconinc marked this conversation as resolved.
Show resolved Hide resolved
## A point along a track
edm4eic::TrackPoint:
Members:
Expand Down Expand Up @@ -433,22 +433,16 @@ datatypes:

edm4eic::Vertex:
Description: "EIC vertex"
Author: "W. Armstrong, S. Joosten, based off EDM4hep"
Author: "J. Osborn"
Members:
- int32_t primary // Boolean flag, if vertex is the primary vertex of the event
- int32_t type // Type flag, to identify what type of vertex it is (e.g. primary, secondary, generated, etc.)
osbornjd marked this conversation as resolved.
Show resolved Hide resolved
- float chi2 // Chi-squared of the vertex fit
- float probability // Probability of the vertex fit
- edm4hep::Vector3f position // [mm] position of the vertex.
- int ndf // NDF of the vertex fit
wdconinc marked this conversation as resolved.
Show resolved Hide resolved
- edm4hep::Vector4f position // [mm] position + time t0 of the vertex.
wdconinc marked this conversation as resolved.
Show resolved Hide resolved
## this is named "covMatrix" in EDM4hep, renamed for consistency with the rest of edm4eic
- edm4eic::Cov3f positionError // Covariance matrix of the position
- int32_t algorithmType // Type code for the algorithm that has been used to create the vertex - check/set the collection parameters AlgorithmName and AlgorithmType.
## Additional parameter not in EDM4hep: vertex time
- float time // Vertex time
VectorMembers:
- float parameters // Additional parameters related to this vertex - check/set the collection parameter "VertexParameterNames" for the parameters meaning.
OneToOneRelations:
## @TODO: why one and not multiple particles?
- edm4eic::ReconstructedParticle associatedParticle // reconstructed particle associated to this vertex.
- edm4eic::Cov4f positionError // Covariance matrix of the position+time
OneToManyRelations:
- edm4eic::ReconstructedParticle associatedParticles // particles associated to this vertex.

## ==========================================================================
## Kinematic reconstruction
Expand Down
Loading