Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create TrackSeed structure to store the seed info #69

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

ShujieL
Copy link
Contributor

@ShujieL ShujieL commented Jan 27, 2024

Briefly, what does this PR introduce?

Create TrackSeed structure to store the seed info

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [x ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no breaking change. Corresponding EICrecon algorithms will be updated to use the data structure. No impact until then.

Does this PR change default behavior?

N/A

@ShujieL ShujieL requested a review from a team as a code owner January 27, 2024 06:11
edm4eic.yaml Outdated Show resolved Hide resolved
edm4eic.yaml Outdated Show resolved Hide resolved
edm4eic.yaml Outdated Show resolved Hide resolved
@wdconinc
Copy link
Contributor

Obviously the checks should pass too.

ShujieL and others added 3 commits January 27, 2024 16:08
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
edm4eic.yaml Outdated Show resolved Hide resolved
edm4eic.yaml Outdated Show resolved Hide resolved
@ShujieL ShujieL requested a review from wdconinc January 30, 2024 22:04
edm4eic.yaml Outdated Show resolved Hide resolved
edm4eic.yaml Outdated Show resolved Hide resolved
@wdconinc wdconinc enabled auto-merge (squash) January 30, 2024 22:20
@wdconinc wdconinc merged commit 6157934 into main Jan 30, 2024
2 checks passed
@wdconinc wdconinc deleted the track_seed branch January 30, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants