Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created data type for hadronic final state variables #74

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tylerkutz
Copy link
Contributor

Briefly, what does this PR introduce?

This creates a data type HadronicFinalState for variables summed over final state hadrons.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

New data type, no breaking changes.

Does this PR change default behavior?

No.

@tylerkutz tylerkutz requested a review from a team as a code owner April 3, 2024 18:59
@tylerkutz tylerkutz linked an issue Apr 3, 2024 that may be closed by this pull request
@mdiefent mdiefent self-requested a review April 4, 2024 19:15
mdiefent

This comment was marked as outdated.

Copy link

@mdiefent mdiefent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the HFS to the data model makes perfect sense. I appreciate the discussion prior in the software & computing channel on Mattermost.

@mdiefent mdiefent merged commit cc887f9 into main Apr 4, 2024
3 checks passed
@mdiefent mdiefent deleted the 73-add-data-type-for-hadronic-final-state-variables branch April 4, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data type for hadronic final state variables
2 participants