Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): avoid python3.10 reference; don't install bokeh, pygithub #1629

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

We are using python3.11 now, so the pip install would install to ~/.local/lib/python3.11/site-packages if it did anything, and the hardcoded PYTHONPATH prepend would then fail to find the module. That this continued to work demonstrates that we don't need to install anything locally, and can get rid of the PYTHONPATH modifications too.

This PR removes the PYTHONPATH additions and the custom pip install. If an update to the bokeh and pygithub packages are needed, then this is better handled by updating what is in the container, now that we have reached a more stable capybara stage of development.

What kind of change does this PR introduce?

  • Bug fix (issue: hardcoded reference to python3.10)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, of course

@veprbl veprbl enabled auto-merge October 10, 2024 23:41
@veprbl veprbl added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit fd1b1dc Oct 11, 2024
55 of 57 checks passed
@veprbl veprbl deleted the python3.10 branch October 11, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants