Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIC sampling fraction update #1642

Merged
merged 1 commit into from
Oct 26, 2024
Merged

BIC sampling fraction update #1642

merged 1 commit into from
Oct 26, 2024

Conversation

mhkim-anl
Copy link
Contributor

Briefly, what does this PR introduce?

Sampling fraction of the BIC ScFi layer has been updated using 5 GeV photons generated at eta = 0.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Sampling fraction of the BIC ScFi layer has been updated.
@mhkim-anl mhkim-anl linked an issue Oct 25, 2024 that may be closed by this pull request
@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: barrel labels Oct 25, 2024
@veprbl
Copy link
Member

veprbl commented Oct 25, 2024

There is a slight $\eta$-dependence
https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/4044559/artifacts/file/results/ecal_gaps/ecal_gap_e-_5GeV_EcalBarrelScFi.png

You can either parametrize it via $z$ readout segmented as
https://github.com/eic/epic/blob/4bb200ff4e3e6f6e1b43bba55a2dc72dc9b44a4c/compact/ecal/bic/bic.xml#L370

or you can add calculation for eta variable to

std::function hit_to_map = [this](const edm4hep::RawCalorimeterHit &h) {
std::unordered_map<std::string, double> params;
for(const auto &p : id_spec.fields()) {
const std::string &name = p.first;
const dd4hep::IDDescriptor::Field* field = p.second;
params.emplace(name, field->value(h.getCellID()));
trace("{} = {}", name, field->value(h.getCellID()));
}
return params;
};
and use that

@veprbl veprbl added this pull request to the merge queue Oct 26, 2024
Merged via the queue into main with commit 593f51b Oct 26, 2024
82 of 86 checks passed
@veprbl veprbl deleted the sampling-fraction-update-mhkim branch October 26, 2024 01:21
@mhkim-anl
Copy link
Contributor Author

@veprbl Thank you approving my pull request. I'm also appreciative of your comments. I'll refer to the slight eta dependence for my further sampling fraction and reconstruction studies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sampling fraction update of the Barrel Imaging Calorimeter
2 participants