Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import new MARCO field map from wiki (link below) #16

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR adds the new magnetic field map from https://wiki.bnl.gov/EPIC/images/7/75/MARCO_v.7.6.2.2.11_1.7T_Magnetic_Field_Map_2024_05_02_rad_coords_%28mm%29_%28T%29.BMap.txt

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested review from veprbl and kkauder May 17, 2024 18:23
@wdconinc
Copy link
Contributor Author

MARCO_v.7.6.2.2.11_1.7T_Magnetic_Field_Map_2024_05_02_rad_coords_(mm)_(T).BMap.txt doesn't actually seem to have positions in mm...

@kkauder
Copy link
Contributor

kkauder commented May 17, 2024

MARCO_v.7.6.2.2.11_1.7T_Magnetic_Field_Map_2024_05_02_rad_coords_(mm)_(T).BMap.txt doesn't actually seem to have positions in mm...

Good catch

@veprbl veprbl mentioned this pull request May 20, 2024
2 tasks
@wdconinc wdconinc merged commit 81182bf into main Jun 3, 2024
@wdconinc wdconinc deleted the marco-v.7.6.2.2.11 branch June 3, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants