-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more vacuum at z>40m #720
Conversation
There is a small extrusion from the world_volume, is that due to a rotation? |
Perhaps some rotated width is not accounted for. |
The introduced vacuum volume (tube) is placed between the last magnet (at z=40.74293743+4.4/2 meter) and the end of the physical volume (at z = 100 meters) and aligned with the last magnet rotation angle of -28.22mrad. The tube has radius of 4 times the B2 magnet radius (4*0.2 m). Hence at the end of the physical volume small part of the tube extends beyond the edge: I'm open to suggestions. The easiest will be to shorten the length by |
This is exactly what we want. Ideally, this is done in the compact xml file as an expression. |
Would the CutTube approach (example present in the same file) be slightly better than shortening a tube. |
to reduce the length use a correct sign of the crossing angle
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Briefly, what does this PR introduce?
This RP will fill the hadron line downstream with a vacuum to allow faster simulation of ion fragments.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Besides the execution time, this PR should keep the results unchanged.
Does this PR change default behavior?
no