Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more vacuum at z>40m #720

Merged
merged 13 commits into from
May 30, 2024
Merged

Add more vacuum at z>40m #720

merged 13 commits into from
May 30, 2024

Conversation

michael-pitt
Copy link
Contributor

@michael-pitt michael-pitt commented May 5, 2024

Briefly, what does this PR introduce?

This RP will fill the hadron line downstream with a vacuum to allow faster simulation of ion fragments.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: This makes the simulation run faster in case of eA collisions in which ions (or ion fragments) are defined as stable particles and propagate downstream the Hadron beamline (x10 improvement).

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Besides the execution time, this PR should keep the results unchanged.

Does this PR change default behavior?

no

@michael-pitt michael-pitt requested a review from ajentsch May 5, 2024 19:45
@github-actions github-actions bot added the topic: far-forward Deterctors for small-angle particles label May 5, 2024
@michael-pitt
Copy link
Contributor Author

michael-pitt commented May 14, 2024

Hi @wdconinc and @ajentsch

This update was communicated to the FF WG, and it is ready to be merged with the master. It should improve the execution time of the simulation for some processes involving particles that propagate downstream the hadronic beampipe

ajentsch
ajentsch previously approved these changes May 14, 2024
src/magnetVacuumFF.cpp Outdated Show resolved Hide resolved
@veprbl
Copy link
Member

veprbl commented May 17, 2024

There is a small extrusion from the world_volume, is that due to a rotation?

@veprbl
Copy link
Member

veprbl commented May 17, 2024

Perhaps some rotated width is not accounted for.

@michael-pitt
Copy link
Contributor Author

michael-pitt commented May 21, 2024

The introduced vacuum volume (tube) is placed between the last magnet (at z=40.74293743+4.4/2 meter) and the end of the physical volume (at z = 100 meters) and aligned with the last magnet rotation angle of -28.22mrad. The tube has radius of 4 times the B2 magnet radius (4*0.2 m). Hence at the end of the physical volume small part of the tube extends beyond the edge:

image

I'm open to suggestions. The easiest will be to shorten the length by 0.2*4*tan(-28.22*mrad) meters

@veprbl
Copy link
Member

veprbl commented May 21, 2024

I'm open to suggestions. The easiest will be to shorten the length by 0.2x4xtan(-28.22mrad)

This is exactly what we want. Ideally, this is done in the compact xml file as an expression.

@simonge
Copy link
Contributor

simonge commented May 21, 2024

I'm open to suggestions. The easiest will be to shorten the length by 0.2x4xtan(-28.22mrad)

This is exactly what we want. Ideally, this is done in the compact xml file as an expression.

Would the CutTube approach (example present in the same file) be slightly better than shortening a tube.

michael-pitt and others added 2 commits May 21, 2024 19:29
to reduce the length use a correct sign of the crossing angle
@veprbl veprbl added this to the 24.06.0 milestone May 25, 2024
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks fine

@veprbl veprbl added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@veprbl veprbl added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 29, 2024
@veprbl veprbl added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 3fd9d7b May 30, 2024
109 checks passed
@veprbl veprbl deleted the addVacuum_FF_endWorld branch May 30, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: far-forward Deterctors for small-angle particles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants