Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material map #741

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update material map #741

merged 1 commit into from
Jun 4, 2024

Conversation

ShujieL
Copy link
Contributor

@ShujieL ShujieL commented Jun 3, 2024

New material map for craterlake with updated service cones. See https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/153#note_27320

Briefly, what does this PR introduce?

Update material map for the new service cone

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [x ] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • [x ] Tests for the changes have been added
  • Documentation has been added / updated
  • [x ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

N/A

Does this PR change default behavior?

it should improve the EICrecon/ACTS tracking performance.

New material map for craterlake with updated service cones. See https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/153#note_27320
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand how to use the material_map artifact to validate this. Can confirm that this doesn't completely break the reconstruction.

@veprbl
Copy link
Member

veprbl commented Jun 4, 2024

Looks like this improves number of hits per track?

image

@veprbl veprbl added this to the 24.06.0 milestone Jun 4, 2024
@veprbl
Copy link
Member

veprbl commented Jun 4, 2024

@veprbl veprbl added this pull request to the merge queue Jun 4, 2024
@Simple-Shyam
Copy link

Simple-Shyam commented Jun 4, 2024

Looks like this improves number of hits per track?

image

@veprbl @ShujieL I was expecting this behavior to increase the number of hits as mentioned during tracking meeting. That's why I said material map should be updated. When it will be added to calibrations/ directory?

@ShujieL
Copy link
Contributor Author

ShujieL commented Jun 4, 2024

Looks like this improves number of hits per track?

image

Great! That means the algorithm finds more measurements within the chi2 cut now. Let's see how much of this will reflect in the tracking performance study

Merged via the queue into main with commit 7fc3780 Jun 4, 2024
111 checks passed
@veprbl veprbl deleted the matmap branch June 4, 2024 05:27
@veprbl
Copy link
Member

veprbl commented Jun 4, 2024

@Simple-Shyam This will be available soon in 24.06.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants