Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BIC configurable, add optional setup with 6 layers. #773

Merged
merged 10 commits into from
Aug 22, 2024
Merged

Conversation

sly2j
Copy link
Contributor

@sly2j sly2j commented Aug 21, 2024

Briefly, what does this PR introduce?

Add an optional setup with a BIC configuration that has all six silicon layers instrumented (versus the current default where only four out of six slots are instrumented). This fully instrumented setup is needed to do further layer optimization studies.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@github-actions github-actions bot added topic: infrastructure Regarding build system, CI, CD topic: calorimetry topic: barrel Mid-rapidity detectors labels Aug 21, 2024
@sly2j sly2j changed the title Renamed 'barrel_interlayers' --> 'bic_default' Make BIC configurable, add optional setup with 6 layers. Aug 21, 2024
@sly2j sly2j requested a review from wdconinc August 21, 2024 21:58
@sly2j sly2j marked this pull request as ready for review August 21, 2024 22:00
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. Minor comment on naming.

compact/ecal/bic/bic.xml Outdated Show resolved Hide resolved
@sly2j sly2j added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit f8f39a1 Aug 22, 2024
115 checks passed
@sly2j sly2j deleted the bic-6layers branch August 22, 2024 15:43
@veprbl veprbl added this to the 24.09.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel Mid-rapidity detectors topic: calorimetry topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants