Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: install.conf.yaml shell commands configuration #25

Open
yasinmiran opened this issue May 30, 2021 · 1 comment · May be fixed by #26
Open

Refactor: install.conf.yaml shell commands configuration #25

yasinmiran opened this issue May 30, 2021 · 1 comment · May be fixed by #26

Comments

@yasinmiran
Copy link
Contributor

yasinmiran commented May 30, 2021

Describe the suggestion

Currently, we repeat the dotbot's shell configs in every instruction.

- shell:
- command: ./setup_homebrew.zsh
stdout: true
stderr: true
- command: ./setup_zsh.zsh
stdout: true
stderr: true
- command: ./setup_node.zsh
stdout: true
stderr: true
- command: ./setup_macos.zsh
stdout: true
stderr: true

Describe the improvement

We can simply add them to dotbot's default configurations to prevent duplication. Like the following: -

- defaults:
    shell:
      stdout: true
      stderr: true

What if one of them is different?

If want to override these configurations at some point, say i.e., turn off stderr for a specific shell command (let's say setup_node script), we can simply add the same configuration as we used to do. When dotbot sees this it will turn off
stderr when running setup_node.

- command: ./setup_node.zsh
  stderr: false 
yasinmiran added a commit to yasinmiran/dotfiles_macos that referenced this issue May 30, 2021
With dotbot's default shell configurations we can simply keep
only the executable path.

Closes eieioxyz#25
yasinmiran added a commit to yasinmiran/dotfiles_macos that referenced this issue May 30, 2021
With dotbot's default shell configurations we can simply keep
only the executable path.

Closes eieioxyz#25
@yasinmiran yasinmiran linked a pull request May 30, 2021 that will close this issue
@WhatsThatItsPat
Copy link

I like it, Yasin. I'll accept the PR after I've had a chance to think about what kind of lesson I can make from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants