Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EI Documentation update regarding API Token usage in Jenkins authentication for subscription #520

Merged

Conversation

dhruvin-kalavadia
Copy link
Contributor

Applicable Issues

Subscription notification getting missed for Jenkins job trigger due to 403 invalid crumb exception.

Description of the Change

Updated documentation with below details.
As improved CSRF protection provided since Jenkins version 2.176.2, it is recommended that to set this Password/Token field as an API token and not Jenkins user password.

Benefits

It will provide improved CSRF protection to trigger Jenkins job by subscription notification.

Possible Drawbacks

Improved CSRF protection provided since Jenkins version 2.176.2, there are chances of subscription notifications getting missed with 403 exception due to session id check in case of Jenkins user password used in subscriptions.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Dhruvin Kalavadia dhruvin.kalavadia@tcs.com

@dhruvin-kalavadia dhruvin-kalavadia marked this pull request as ready for review January 17, 2022 12:27
@Surya-Kolli Surya-Kolli merged commit b9635f2 into eiffel-community:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants