-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support #296
Add Windows support #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this addition!
Please use ${path.sep}
everywhere to replace the hardcoded unix path separators /
.
Once merged I will add tests on windows runners
Maybe only changing |
It is not enough. Please also change the other occurrences such as the workingDir |
Tried my best to find all hardcoded unix path separators /. |
There are some lint errors. |
Saw those. I am currently trying to find out why it complains here but nowhere else |
Lets use |
This reverts commit d5b56b4.
Ok, that commit has been reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Awesome! Thank you for your contribution!
Fix #10, and tested on my project https://github.com/he0119/nonebot-plugin-user/actions/runs/9900996813.
Should have a lot of room for improvement.
Tool cache seems to be broken.