Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stretch goals: Introduce Session-based Request Distribution #62

Closed
zvolin opened this issue Sep 8, 2023 · 3 comments · Fixed by #130
Closed

stretch goals: Introduce Session-based Request Distribution #62

zvolin opened this issue Sep 8, 2023 · 3 comments · Fixed by #130

Comments

@zvolin
Copy link
Member

zvolin commented Sep 8, 2023

No description provided.

@oblique
Copy link
Member

oblique commented Sep 16, 2023

Session needs to handle partial range responses: #67 (comment)

@oblique
Copy link
Member

oblique commented Sep 18, 2023

Since partial responses are allowed:

  • Here we should return the error only if vector is empty.
  • Here in case of failure if some headers passed verification, we should return them instead of an error.

Session should retry requesting the remaining range.

@oblique
Copy link
Member

oblique commented Sep 18, 2023

We need to figure out this: Should requests that failed because of a connection error be retried?

@oblique oblique moved this from Todo to In Progress in Lumina Oct 16, 2023
@zvolin zvolin linked a pull request Nov 13, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lumina Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants
@oblique @zvolin and others