Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node/exchange): Request HEAD from multiple peers and choose the best result #67

Merged
merged 24 commits into from
Sep 18, 2023
Merged

feat(node/exchange): Request HEAD from multiple peers and choose the best result #67

merged 24 commits into from
Sep 18, 2023

Conversation

oblique
Copy link
Member

@oblique oblique commented Sep 14, 2023

No description provided.

zvolin
zvolin reviewed Sep 14, 2023
View reviewed changes
node/src/peer_tracker.rs Outdated Show resolved Hide resolved
fl0rek
fl0rek reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Show resolved Hide resolved
node/src/exchange/client.rs Outdated Show resolved Hide resolved
node/src/peer_tracker.rs Outdated Show resolved Hide resolved
oblique and others added 2 commits September 15, 2023 19:21
@oblique
validate response of the request
1352ef7
@oblique @zvolin
Update node/src/peer_tracker.rs
74415b6 
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
fl0rek
fl0rek approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 🎸

zvolin
zvolin reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
oblique and others added 5 commits September 16, 2023 00:29
@oblique
make match a bit better
a5f38d6
@oblique
rename Req to Sender
063477a
@oblique
return Vec from best_n_peers
fba3d37
@oblique @zvolin
Update node/src/exchange/client.rs
2e51234 
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
@oblique @zvolin
Update node/src/exchange/client.rs
6028936 
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
zvolin
zvolin reviewed Sep 15, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
oblique
oblique commented Sep 16, 2023
View reviewed changes
node/src/exchange/client.rs Outdated Show resolved Hide resolved
@oblique oblique mentioned this pull request Sep 16, 2023
Closed
fl0rek
fl0rek approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@fl0rek fl0rek merged commit 8df7715 into eigerco:main Sep 18, 2023
4 checks passed
@oblique oblique deleted the feat/exhange-client-parallel-head branch September 30, 2023 06:08
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Closed
@zvolin zvolin mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@fl0rek fl0rek fl0rek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oblique @fl0rek @zvolin