Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Yield between multiple ExtendedHeader::validate #107

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

oblique
Copy link
Member

@oblique oblique commented Oct 16, 2023

No description provided.

Validation is computation heavy, so yield is needed.
Request with height 270228 and amount 512 reponds back with 16mb,
however our limit is 10mb. So we allow returning a partial response.
@oblique oblique requested review from zvolin and fl0rek October 16, 2023 09:44
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎸

node/Cargo.toml Show resolved Hide resolved
@fl0rek fl0rek merged commit 6de167f into eigerco:main Oct 16, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@zvolin zvolin mentioned this pull request Jan 12, 2024
@oblique oblique deleted the fix/async-validate branch April 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants