chore: Make sure we run clippy for wasm and fix wasm build/lints #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0rek
force-pushed
the
chore/fix-wasm-clippy
branch
from
6c3b115
to
2ca63d6
Compare
fl0rek
force-pushed
the
chore/fix-wasm-clippy
branch
from
c6c097c
to
7d6b53f
Compare
|
Converted it to draft since it has many |
oblique
reviewed
Nov 14, 2023
zvolin
reviewed
Nov 14, 2023
fl0rek
force-pushed
the
chore/fix-wasm-clippy
branch
from
877891c
to
e0544a4
Compare
fl0rek
force-pushed
the
chore/fix-wasm-clippy
branch
from
e0544a4
to
2d32e58
Compare
* feat(types): Aadd `wasm-bindgen` feature flag fixes eigerco#131 * fix cargo.toml * upgrade tendermint
zvolin
reviewed
Nov 15, 2023
fl0rek
force-pushed
the
chore/fix-wasm-clippy
branch
from
fd2d7a4
to
47bf77e
Compare
oblique
approved these changes
Nov 17, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added running clippy for wasm32.
Disabled
p2pfeature gated test for rpc, as there's no obvious way to set up test libp2p nodes in wasm (which is why tiny-node is also compiled out).rpc/tests/utils/client.rs- reorganised code in anticipation of implementing jsonrpc using wasm-client. It seems like we need a way to get auth token (for native it we get it from the environment) and send it alongside the request in header.Fixed missed wasm clippy issues