Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return bootstrap peers as iterator and filter relevant ones #147

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

zvolin
Copy link
Member

@zvolin zvolin commented Nov 16, 2023

No description provided.

@oblique
Copy link
Member

oblique commented Nov 16, 2023

Is this for minimizing the "not supported" logs? Or it fixes something else too?

@zvolin
Copy link
Member Author

zvolin commented Nov 16, 2023

it's mostly the UX change I'd say, you are presented with many bootstrap peers for each network but they are all not working. That way we can show the true state to the user

celestia/src/server.rs Outdated Show resolved Hide resolved
node-wasm/src/node.rs Outdated Show resolved Hide resolved
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@fl0rek fl0rek merged commit 35ac964 into eigerco:main Nov 17, 2023
5 checks passed
@zvolin zvolin deleted the feat/filter-bootstrap-peers branch November 17, 2023 11:12
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
This was referenced Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants