Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multihash for NMT node data #153

Merged
merged 13 commits into from
Dec 11, 2023
Merged

Add Multihash for NMT node data #153

merged 13 commits into from
Dec 11, 2023

Conversation

fl0rek
Copy link
Member

@fl0rek fl0rek commented Nov 22, 2023 •
edited
Loading

closes #142

@fl0rek fl0rek marked this pull request as ready for review November 24, 2023 08:37
@fl0rek fl0rek requested review from zvolin and oblique and removed request for zvolin November 24, 2023 08:47
zvolin
zvolin reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, left some ideas

types/src/multihash.rs Outdated Show resolved Hide resolved
types/src/multihash.rs Outdated Show resolved Hide resolved
types/src/multihash.rs Outdated Show resolved Hide resolved
types/src/multihash.rs Outdated Show resolved Hide resolved
types/src/multihash.rs Outdated Show resolved Hide resolved
@Wondertan
Copy link

Is this ipldv2 mh?

@fl0rek fl0rek requested a review from zvolin November 30, 2023 12:14
oblique
oblique reviewed Dec 1, 2023
View reviewed changes
types/src/axis.rs Outdated Show resolved Hide resolved
types/src/axis.rs Show resolved Hide resolved
types/src/axis.rs Outdated Show resolved Hide resolved
types/src/axis.rs Outdated Show resolved Hide resolved
types/src/axis.rs Show resolved Hide resolved
types/src/axis.rs Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/sample.rs Show resolved Hide resolved
zvolin
zvolin reviewed Dec 6, 2023
View reviewed changes
types/src/multihash.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Dec 6, 2023
View reviewed changes
types/src/multihash.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor things but LGTM in general

@fl0rek fl0rek force-pushed the feat/multihash-nmt branch 5 times, most recently from 91323ce to 46bd441 Compare December 8, 2023 08:24
oblique
oblique approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zvolin zvolin merged commit 0ab21ab into eigerco:main Dec 11, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Closed
@zvolin zvolin mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@oblique oblique oblique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmt-rs Multihash compatibility
4 participants
@fl0rek @Wondertan @oblique @zvolin