refactor: error message for missing token and cleanups #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
requested changes
Dec 28, 2023
There was a problem hiding this comment.
Hey
This approach was functional but not optimal in terms of clarity and efficiency.
The efficiency here is equal, as the changes are noop. In terms of clarity tho, we rather prefer what we had in places I mentioned.
We're happy to merge the rest of changes tho if you'd like to remove those two
zvolin
changed the title
zvolin
approved these changes
Dec 29, 2023
fl0rek
approved these changes
Dec 29, 2023
|
It looks like there is another issue, we have a requirement for commits to be signed. Would you mind signing the commits you made? |
auto-merge was automatically disabled
December 29, 2023 14:07
Head branch was pushed to by a user without write access
Signed the commits and updated. Please check. Thank you. |
|
looking good, thanks @codeesura |
Closed
This was referenced Jan 12, 2024
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a refactoring to the
fetch_bridge_multiaddrsfunction in codebase, specifically targeting the way TCP protocol filtering is handled.Changes
Previously, the function utilized a
.filter()and.map()combination to process Multiaddr elements, which could include TCP protocols. This approach was functional but not optimal in terms of clarity and efficiency. To enhance the code quality, I've refactored this segment using.filter_map(), which combines filtering and mapping in a more concise manner.