Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add shwap data types #169

Merged
merged 21 commits into from
Jan 12, 2024
Merged

feat(node): Add shwap data types #169

merged 21 commits into from
Jan 12, 2024

Conversation

fl0rek
Copy link
Member

@fl0rek fl0rek commented Dec 19, 2023

No description provided.

@Wondertan
Copy link

Hey @fl0rek.

We had to make some changes to shwap, which landed in this commit. The TLDR is described in the commit-msg.

@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch 3 times, most recently from fb4611c to 0dd351a Compare January 7, 2024 21:03
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from 0dd351a to 92b6b1f Compare January 7, 2024 21:16
@fl0rek fl0rek marked this pull request as ready for review January 8, 2024 08:20
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from a4cc7f5 to bf21388 Compare January 8, 2024 09:05
zvolin
zvolin reviewed Jan 8, 2024
View reviewed changes
types/src/namespaced_data.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Jan 8, 2024
View reviewed changes
types/src/row.rs Outdated Show resolved Hide resolved
types/src/row.rs Outdated Show resolved Hide resolved
types/src/row.rs Outdated Show resolved Hide resolved
types/src/row.rs Outdated Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/sample.rs Outdated Show resolved Hide resolved
types/src/error.rs Outdated Show resolved Hide resolved
types/src/extended_data_square.rs Outdated Show resolved Hide resolved
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from f66ab21 to 96e9fe5 Compare January 9, 2024 08:09
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch 2 times, most recently from 5e87d4f to 7f4219f Compare January 9, 2024 08:40
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from 7f4219f to 70e4d41 Compare January 9, 2024 08:45
@fl0rek fl0rek changed the title Add shwap data types feat(node): Add shwap data types Jan 10, 2024
zvolin
zvolin reviewed Jan 10, 2024
View reviewed changes
types/src/share.rs Outdated Show resolved Hide resolved
fl0rek and others added 4 commits January 10, 2024 17:52
@fl0rek @zvolin
Update types/src/share.rs
92d6328 
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@fl0rek
Merge remote-tracking branch 'eiger/main' into feat/shwap-data-types-…
196003c 
…again
@fl0rek
you got me docs
60481ee
@fl0rek
Last of the Missing Documentations
2bc4dab
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch 6 times, most recently from 32a017c to 350b3db Compare January 12, 2024 09:53
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from 350b3db to 4361077 Compare January 12, 2024 09:57
@fl0rek fl0rek requested a review from oblique January 12, 2024 10:06
zvolin
zvolin reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, last findings I think

types/src/namespaced_data.rs Outdated Show resolved Hide resolved
types/src/namespaced_data.rs Outdated Show resolved Hide resolved
types/src/row.rs Outdated Show resolved Hide resolved
types/src/share.rs Outdated Show resolved Hide resolved
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from fb11b34 to 821b52e Compare January 12, 2024 11:51
fl0rek and others added 2 commits January 12, 2024 14:40
@fl0rek @zvolin
Update types/src/namespaced_data.rs
7b14d5b 
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@fl0rek @zvolin
Update types/src/namespaced_data.rs
5271942 
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@fl0rek fl0rek requested a review from zvolin January 12, 2024 14:44
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from e7532f8 to bf97890 Compare January 12, 2024 14:47
zvolin
zvolin approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch 2 times, most recently from dca605b to b4828f6 Compare January 12, 2024 14:54
@fl0rek fl0rek force-pushed the feat/shwap-data-types-again branch from b4828f6 to ab17ad4 Compare January 12, 2024 14:54
@zvolin zvolin enabled auto-merge (squash) January 12, 2024 14:58
@zvolin zvolin merged commit b87fad2 into eigerco:main Jan 12, 2024
6 checks passed
This was referenced Jan 12, 2024
Merged
Closed
@fl0rek fl0rek deleted the feat/shwap-data-types-again branch January 22, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@oblique oblique Awaiting requested review from oblique

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl0rek @Wondertan @zvolin