Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: serialize proof and commitment #19

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat: serialize proof and commitment #19

merged 1 commit into from
Jul 3, 2023

Conversation

oblique
Copy link
Member

@oblique oblique commented Jul 3, 2023 •
edited
Loading

closes #16

zvolin
zvolin approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left 2 nits

types/src/nmt.rs Outdated Show resolved Hide resolved
types/src/blob/commitment.rs Outdated Show resolved Hide resolved
@oblique oblique requested a review from zvolin July 3, 2023 19:29
@zvolin zvolin merged commit a921c5a into eigerco:main Jul 3, 2023
@oblique oblique deleted the feat/ser-proof branch July 18, 2023 06:05
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Closed
@zvolin zvolin mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin Awaiting requested review from zvolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a serializable struct for Proof
2 participants
@oblique @zvolin