feat(rpc): Implement WASM Client #210
Conversation
There was a problem hiding this comment.
This looks nice.
For the wasm test to properly execute we'd need to add the mentioned flag here.
One thing I'm wondering about is that when it's released and the flag is added, we will no longer need tokens in other tests, but also then we'll have no way to test with token
|
we could run 2 bridge nodes and only one with |
distractedm1nd
force-pushed
the
wasm-client
branch
from
d3ec78d to
33459bb
Compare
|
Hey, I had to take an unexpected break for 2 months but I am back. I have implemented the review changes AFAIU, so I think this should be ready to go soon. The one thing that I'm unsure about is that now run-bridge uses skip-auth, so the auth mechanism is not actually being tested. If there are tests for the negative case I'm assuming CI will fail on this PR |
There was a problem hiding this comment.
Thanks for helping us out!
We still might want to test with auth enabled, but as you've noted we aren't covering negative auth cases now, so that's not a hard requirement and we can fix that later by ourselves.
I think once CI is running and green we can get this merged 🎸
distractedm1nd
force-pushed
the
wasm-client
branch
3 times, most recently
from
2dc94f3 to
b1ec907
Compare
|
Hey @distractedm1nd, all looks good but the merge is blocked due to the unsigned commits. Would you mind signing them with your gpg key and force pushing? |
feat: wasm client fix: updating run-bridge to use skip auth, organizing imports fix(ci): adding wasm-pack for rpc crate fixing workflow to run wasm test as integration test fix: using wasm-bindgen feature flag
distractedm1nd
force-pushed
the
wasm-client
branch
from
e9c8e8c to
d4245ae
Compare
|
@zvolin I've squashed all the commits into a single, signed commit. Hope this is fine |
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
|
Thank @distractedm1nd! |
This PR adds a WASM-compatible Client implementation. I am fairly new to Rust, so apologies if there is an easier way to get around the trait implementations.
jsonrpsee-wasm-client only supports Websocket, and also does not have the ability to set headers. This means that celestia-node needs to run with
--rpc.skip-auth, which is coming out in the next release.