feat: Add requesting storage persistence for more quota #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
reviewed
Jul 2, 2024
zvolin
reviewed
Jul 3, 2024
fl0rek
force-pushed
the
feat/request_persistent_storage
branch
from
637ae67
to
2cb17e8
Compare
oblique
approved these changes
Jul 4, 2024
zvolin
approved these changes
Jul 5, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #317
MDN page isn't exact on the details (as detail vary by browser), but requesting persistent storage on firefox raises the quota limit (and eliminates quota issues on my machine).
Browsers should also try more to keep our data from being removed.
Node that this will display prompt on Firefox, while chromium based browsers use heuristics to figure out whether to grant the storage.