Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node)!: Refactor BlockRanges and optimize data sampling queue population #320

Merged
merged 47 commits into from
Jul 9, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Jul 3, 2024

No description provided.

@oblique oblique changed the title feat(node)!: Optimize data sampling queue population feat(node)!: Refactor BlockRanges and optimize data sampling queue population Jul 5, 2024
@oblique oblique marked this pull request as ready for review July 5, 2024 12:31
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
@oblique oblique requested a review from zvolin July 8, 2024 13:14
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly grammar suggestions

node/src/store.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/block_ranges.rs Outdated Show resolved Hide resolved
node/src/store/indexed_db_store.rs Outdated Show resolved Hide resolved
node/src/store/indexed_db_store.rs Outdated Show resolved Hide resolved
oblique and others added 5 commits July 8, 2024 16:52
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
@oblique oblique requested a review from fl0rek July 8, 2024 14:58
node/src/store.rs Outdated Show resolved Hide resolved
node/src/store/indexed_db_store.rs Show resolved Hide resolved
node/src/store/indexed_db_store.rs Outdated Show resolved Hide resolved
node/src/store/indexed_db_store.rs Outdated Show resolved Hide resolved
node/src/store/indexed_db_store.rs Outdated Show resolved Hide resolved
node/src/block_ranges.rs Outdated Show resolved Hide resolved
oblique and others added 6 commits July 9, 2024 11:02
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
@oblique oblique requested a review from fl0rek July 9, 2024 09:47
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎸

@fl0rek fl0rek merged commit 1fa1bbf into eigerco:main Jul 9, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Jul 9, 2024
@zvolin zvolin mentioned this pull request Jul 25, 2024
@zvolin zvolin mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants