Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node)!: Do not skip header-sub reports when store writes are slow #333

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Jul 15, 2024

No description provided.

@oblique
Copy link
Member Author

oblique commented Jul 15, 2024

This contains #332 commits. Will be rebased after #332 is merged.

@oblique oblique force-pushed the fix/header-sub-recv branch 2 times, most recently from f3a3f65 to 932fe61 Compare July 15, 2024 10:25
@oblique oblique requested a review from zvolin July 16, 2024 20:54
@oblique oblique marked this pull request as ready for review July 16, 2024 20:54
node/src/syncer.rs Outdated Show resolved Hide resolved
node/src/syncer.rs Outdated Show resolved Hide resolved
@oblique
Copy link
Member Author

oblique commented Jul 20, 2024

CI is failing because of this: Sovereign-Labs/nmt-rs#30

node/src/p2p.rs Outdated Show resolved Hide resolved
node/src/syncer.rs Outdated Show resolved Hide resolved
oblique and others added 2 commits July 22, 2024 10:01
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
Signed-off-by: Yiannis Marangos <psyberbits@gmail.com>
@oblique oblique requested review from fl0rek and zvolin July 22, 2024 07:02
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@fl0rek fl0rek merged commit 4023855 into eigerco:main Jul 25, 2024
6 checks passed
This was referenced Jul 25, 2024
@zvolin zvolin mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants