Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Prost build issue. #467

Closed

Conversation

musitdev
Copy link

Using the current main branch, if the Cargo.lock file is removed the build fails with the error:

error[E0277]: the trait bound `celestia_tendermint_proto::v0_34::types::ValidatorSet: prost::Message` is not satisfied
    --> target/debug/build/celestia-proto-d9e58f87878dccfd/out/header.pb.rs:5:28
     |
5    | #[derive(Clone, PartialEq, ::prost::Message)]
     |                            ^^^^^^^^^^^^^^^^ the trait `prost::Message` is not implemented for `celestia_tendermint_proto::v0_34::types::ValidatorSet`
     |
     = help: the following other types implement trait `prost::Message`:

The issue comes from the fact that the crate celestia-tendermint-proto use the post version 0.13.3 and the proto crate the version 0.12.6.
I've changed the dependencies version to 0.13.3 but kept the build-dependencies to the old one because otherwise, build.rs doesn't build.

@zvolin
Copy link
Member

zvolin commented Nov 15, 2024

Yeah, we saw it. The issue is that the celestia-tendermint-proto doesn't follow semver. We were discussing it and thinking about yanking that celestia-tendermint release. Unless it's an issue for you, we'd prefer fixing it by merging #454 for which celestia-tendermint was released and then abandoning celestia-tendermint completely in #463

@musitdev
Copy link
Author

Ok I see. No need to merge if you have another plan to correct it. For now, we'll use our fork and when it will be solved, we'll switch. I'm little surprised that no other users find this issue. Perhaps it's still hidden for them, but you're going to have more and more user that get it.

@zvolin
Copy link
Member

zvolin commented Nov 18, 2024

we have yanked 0.32.3 release of celestia-tendermint and we will release the new (hopefully last) version of it as 0.33.0. This should fix the issue and sorry for breaking semver in the first place 🙏

@zvolin zvolin closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants