Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exchange): Add pre-allocating the buffer for reading in HeaderCodec #64

Merged
merged 20 commits into from
Sep 12, 2023
Merged

feat(exchange): Add pre-allocating the buffer for reading in HeaderCodec #64

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
888ed6e
Add preallocating buffer when reading header request
fl0rek Sep 11, 2023
5ea68a5
Avoid having exchange public
fl0rek Sep 11, 2023
37590d9
Also use it in read_response, add tests for too long msg
fl0rek Sep 11, 2023
84f71d2
code comment cleanup
fl0rek Sep 11, 2023
ac24d3b
Merge branch 'main' into feat/header-request-pre-alloc
fl0rek Sep 11, 2023
f3d8d36
Read multiple messages from single stream
fl0rek Sep 11, 2023
f70b960
typpo
fl0rek Sep 11, 2023
5ef3495
Multiple requests only for HeaderResponse
fl0rek Sep 11, 2023
0e81ea1
Make sure to only read single request for HeaderRequest
fl0rek Sep 11, 2023
f18a99d
Handle varint overflow
fl0rek Sep 12, 2023
ebb0c69
fix handling of multiple short requests in a message
fl0rek Sep 12, 2023
05d03fb
cleanup
fl0rek Sep 12, 2023
274aca2
use total msg len
fl0rek Sep 12, 2023
f813b05
possibly optimize number of reads
fl0rek Sep 12, 2023
b6db0f4
Apply suggestions from code review
fl0rek Sep 12, 2023
c5294d6
Apply suggestions from code review
fl0rek Sep 12, 2023
1eebc2a
fix for read buffer prealloc, style changes
fl0rek Sep 12, 2023
13f3fca
Merge remote-tracking branch 'origin/feat/header-request-pre-alloc' i…
fl0rek Sep 12, 2023
559569d
Address PR comments
fl0rek Sep 12, 2023
a73579b
retype read_message
fl0rek Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions node/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ celestia-types = { workspace = true }
tendermint-proto = { workspace = true }

async-trait = "0.1.73"
bytes = "1.4.0"
oblique marked this conversation as resolved.
Show resolved Hide resolved
flume = { version = "0.11.0", default-features = false, features = ["async"] }
futures = "0.3.28"
libp2p = { version = "0.52.3", features = [
Expand Down
Loading
Loading