Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Remove keep_alive::Behaviour #95

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

oblique
Copy link
Member

@oblique oblique commented Oct 6, 2023

This was preventing ping::Behaviour to close a broken connections.

This was preventing `ping::Behaviour` to close a broken connections.
@oblique oblique assigned fl0rek and zvolin and unassigned fl0rek and zvolin Oct 6, 2023
@oblique oblique requested review from fl0rek and zvolin October 6, 2023 09:44
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm wondering what to do with the peer tracker. If nodes will be disconnecting in idle, we shouldn't treat the Identified state as an upgrade of connected but rather the separate thing, like trusted? Also Identified shouldn't affect is_connected, am I correct?

@oblique
Copy link
Member Author

oblique commented Oct 6, 2023

Identified means we received what protocols the node supports after the connection. If it gets disconnected the identification get invalidated because we don't know if process was stopped manually to be started in a different version. Versions can support different protocols.

On the other hand, we don't make any use of this information and I think we will never. So we can remove the Identified state.

@zvolin
Copy link
Member

zvolin commented Oct 6, 2023

Doesn't identify also provide us listening addresses we put into PeerInfo?

@oblique
Copy link
Member Author

oblique commented Oct 6, 2023

True. But we can use add_addresses for that.

@zvolin zvolin merged commit 0558111 into eigerco:main Oct 6, 2023
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@zvolin zvolin mentioned this pull request Jan 12, 2024
@oblique oblique deleted the fix/rm-keep-alive branch April 17, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants