fix: temporary backward compatibility for json proofs #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
force-pushed
the
fix/backward-comp-proof
branch
from
9305d3b
to
b40a15e
Compare
oblique
approved these changes
Oct 6, 2023
fl0rek
approved these changes
Oct 6, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proof representation had breaking change in node v0.11.0-rc14. Previously we were always setting the
ignore_max_nsto true by hand, but since the rc14, we just use the value provided from json (which hadn't existed before). So to keep the compatibility with an order proofs, we should provide atruefor this value if missing (when deserializing proofs in older versions)