Dynamic UI #14
Dynamic UI #14
Conversation
# Conflicts: # app/package-lock.json # app/src/main.ts
This reverts commit 38f538517f766606cb3858317f125c7281324329.
… before parenthesis
There was a problem hiding this comment.
Great job ! Things that i checked:
- Tried the UI locally. UI works with both contracts Lottery and Voting, correctly replacing all values in the CLI command template when pressing the
invokebutton. - Code in general, i think is good for the demo.
- That the targets for the first demo are met (10% of the first milestone)
- Just missing the information for the readme but maybe this is for later.
app/src/Wizard.tsx
Outdated
| </Modal.Header> | ||
| <Modal.Body> | ||
| <p> | ||
| <pre> |
There was a problem hiding this comment.
As a nitpick, would it be possible to add a more "terminal-like" style to the invoke modal ? Currently is in this way:
By adding this style property (playing around):
<pre style={{ backgroundColor: 'black' }}>I was able to get this :) :
I like it more let me know what do you think. Also, i am wondering if the typical button of "copy to clipboard" would be easy to add.
Thanks for the great work 😍
There was a problem hiding this comment.
I can change it. As for the button - it is there and it works :)
There was a problem hiding this comment.
Ah yeah, you mean this one right ? for copying the contract code:
I am suggesting to add the same, but in the invoke modal. So the user can copy the CLI invokation also :)
There was a problem hiding this comment.
Well, maybe needs a bit more of elaboration as, with the code i shared before, affects every modal ofc .....
There was a problem hiding this comment.
Added both the background and button.
There was a problem hiding this comment.
Thank you ! just a last thing i realised when copying the command into the terminal. We need the \ for the new lines 😝 . I took the liberty of pushing this commit df7125b , as i cannot send to you a patch over here (github does not allow patch file extension). Now looks fixed:
But let me know if you agree with it :)
* Created initial UI with boostrap. * Reorganized UI, added settings and generated code for Lottery contract. * Clean up. * Code reformat. * Replaced the static UI with the dynamic one made in React. * Small layout change of buttons. * Code reformat * Revert "Auxiliary commit to revert individual files from 0645906" This reverts commit 38f538517f766606cb3858317f125c7281324329. * Code reformat with linter. * More reformat * Added navbar and readme page. * Code cleanup * Fixed prettier warnings, removed eslint flag to warn of space missing before parenthesis * Removed from eslint checking for trailing comma * Added black background 'copy to clipboard' button to invoke code dialog * Fix line breaks in invoke CLI commands --------- Co-authored-by: eloylp <eloylp@eloylp.dev>
No description provided.