Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(Dockerfile): add Dockerfile and zombienet for parachain #124

Merged
merged 15 commits into from
Jul 18, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Jul 10, 2024

Description

Related to: #114
This PR does two things:

There is some trickery going on, cause we don't wanna publish the docker image yet and zombienet's support for private registries is not there yet (paritytech/zombienet#1829).

Ideally, those workarounds will be gone away and the users will need to have:

  • kubectl configured with some cluster (e.g. minikube)
  • access to a docker image
  • ZombieNet binary

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@th7nder th7nder self-assigned this Jul 10, 2024
@th7nder th7nder force-pushed the feat/114/docker-image branch 6 times, most recently from b9b8847 to cdbc835 Compare July 11, 2024 14:47
@th7nder th7nder force-pushed the feat/114/docker-image branch from cdbc835 to 6dd66d7 Compare July 11, 2024 15:04
@th7nder th7nder marked this pull request as ready for review July 11, 2024 15:04
@th7nder th7nder requested review from jmg-duarte and cernicc July 11, 2024 15:04
@th7nder th7nder added the ready for review Review is needed label Jul 11, 2024
@th7nder th7nder force-pushed the feat/114/docker-image branch from 6dd66d7 to 7152be0 Compare July 11, 2024 16:06
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 11, 2024
docker/dockerfiles/parachain/Dockerfile Outdated Show resolved Hide resolved
Justfile Outdated Show resolved Hide resolved
Justfile Outdated Show resolved Hide resolved
PARACHAIN.md Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/114/docker-image branch from 9c4c338 to d0b430f Compare July 12, 2024 11:22
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 12, 2024
@th7nder th7nder requested review from jmg-duarte and cernicc July 12, 2024 11:54
Justfile Outdated Show resolved Hide resolved
PARACHAIN.md Outdated Show resolved Hide resolved
PARACHAIN.md Outdated Show resolved Hide resolved
PARACHAIN.md Outdated Show resolved Hide resolved
PARACHAIN.md Outdated Show resolved Hide resolved
PARACHAIN.md Outdated Show resolved Hide resolved
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 13, 2024
@th7nder th7nder requested a review from jmg-duarte July 13, 2024 08:08
PARACHAIN.md Outdated Show resolved Hide resolved
@cernicc
Copy link
Member

cernicc commented Jul 15, 2024

I can't get it to work on Linux 😭

./z -p kubernetes spawn zombienet/local-kube-testnet.toml
╔════════════════════╤════════════════════════════════════════════════════════════════════════════════════════════════════╗
║ 🧟 Zombienet 🧟    │ Initiation                                                                                         ║
╟────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────╢
║ Provider           │ kubernetes                                                                                         ║
╟────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────╢
║ Namespace          │ zombie-cb5d39fc343e9e4daf9ca10041c5d18c                                                            ║
╟────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────╢
║ Temp Dir           │ /tmp/zombie-cb5d39fc343e9e4daf9ca10041c5d18c_-592833-26K24LGZsgdv                                  ║
╚════════════════════╧════════════════════════════════════════════════════════════════════════════════════════════════════╝

                 ⚠ Can not access kubernetes, please check your config.
error: Recipe `kube-testnet` failed on line 32 with exit code 1

This is all that zombienet outputs. Any ideas?

I had to start the minikube to get rid of this error. And then when the minikube is started run the just load-to-minikube.

It works.

zombie-e447d49989238c8e9aecceec16e28fd9   alice                              1/1     Running     0               63s
zombie-e447d49989238c8e9aecceec16e28fd9   bob                                1/1     Running     0               51s
zombie-e447d49989238c8e9aecceec16e28fd9   charlie                            1/1     Running     0               42s
zombie-e447d49989238c8e9aecceec16e28fd9   fileserver                         1/1     Running     0               2m48s
zombie-e447d49989238c8e9aecceec16e28fd9   temp                               0/1     Completed   0               2m26s
zombie-e447d49989238c8e9aecceec16e28fd9   temp-1                             0/1     Completed   0               2m26s
zombie-e447d49989238c8e9aecceec16e28fd9   temp-2                             0/1     Completed   0               113s
zombie-e447d49989238c8e9aecceec16e28fd9   temp-3                             0/1     Completed   0               103s
zombie-e447d49989238c8e9aecceec16e28fd9   temp-4                             0/1     Completed   0               96s
zombie-e447d49989238c8e9aecceec16e28fd9   temp-5                             0/1     Completed   0               74s
zombie-e447d49989238c8e9aecceec16e28fd9   temp-collator                      0/1     Completed   0               85s

@th7nder th7nder requested a review from cernicc July 15, 2024 10:58
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 15, 2024
PARACHAIN.md Outdated Show resolved Hide resolved
PARACHAIN.md Show resolved Hide resolved
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 16, 2024
@th7nder th7nder requested a review from cernicc July 16, 2024 08:26
cernicc
cernicc previously approved these changes Jul 16, 2024
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪

@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 16, 2024
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 18, 2024
@jmg-duarte jmg-duarte enabled auto-merge July 18, 2024 12:45
@jmg-duarte jmg-duarte merged commit 4584be6 into develop Jul 18, 2024
3 checks passed
@jmg-duarte jmg-duarte deleted the feat/114/docker-image branch July 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants