-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(Dockerfile): add Dockerfile and zombienet for parachain #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
force-pushed
the
feat/114/docker-image
branch
6 times, most recently
from
July 11, 2024 14:47
b9b8847
to
cdbc835
Compare
th7nder
force-pushed
the
feat/114/docker-image
branch
from
July 11, 2024 15:04
cdbc835
to
6dd66d7
Compare
th7nder
force-pushed
the
feat/114/docker-image
branch
from
July 11, 2024 16:06
6dd66d7
to
7152be0
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 11, 2024
jmg-duarte
requested changes
Jul 11, 2024
cernicc
reviewed
Jul 12, 2024
th7nder
force-pushed
the
feat/114/docker-image
branch
from
July 12, 2024 11:22
9c4c338
to
d0b430f
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 12, 2024
jmg-duarte
requested changes
Jul 12, 2024
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 13, 2024
cernicc
reviewed
Jul 15, 2024
I had to start the minikube to get rid of this error. And then when the minikube is started run the It works.
|
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 15, 2024
cernicc
reviewed
Jul 16, 2024
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 16, 2024
cernicc
previously approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💪
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 16, 2024
jmg-duarte
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jul 18, 2024
cernicc
approved these changes
Jul 18, 2024
jmg-duarte
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: #114
This PR does two things:
There is some trickery going on, cause we don't wanna publish the docker image yet and zombienet's support for private registries is not there yet (paritytech/zombienet#1829).
Ideally, those workarounds will be gone away and the users will need to have:
Checklist