Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commd): calculate commd #423

Merged
merged 26 commits into from
Oct 9, 2024
Merged

feat(commd): calculate commd #423

merged 26 commits into from
Oct 9, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented Oct 3, 2024 •
edited
Loading

Description

I am very very sorry for the large PR, but when I started implementing commd. I noticed that there are other things needed and that stuff was just piling on.

This PR contains:

  • Added PaddedSectorSize and UnpaddedSectorSize. To easier reason what kind of sizes are being passed around.
  • commitments to cids conversions were moved to one place
  • Changed the CommP calculation so that the source received should be already padded
  • Implement the CommD calculation

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Did you document new (or modified) APIs?

@cernicc cernicc added this to the Phase 2 milestone Oct 3, 2024
@cernicc cernicc self-assigned this Oct 3, 2024
@cernicc cernicc linked an issue Oct 3, 2024 that may be closed by this pull request
Market Pallet: port compute_commd #92
Closed
th7nder
th7nder requested changes Oct 3, 2024
View reviewed changes
cli/polka-storage-provider/src/commands/utils/mod.rs Outdated Show resolved Hide resolved
pallets/market/src/commd.rs Outdated Show resolved Hide resolved
pallets/market/src/commd.rs Outdated Show resolved Hide resolved
pallets/market/src/commd.rs Outdated Show resolved Hide resolved
pallets/market/src/commd.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
primitives/proofs/src/types.rs Show resolved Hide resolved
primitives/shared/src/commitment/mod.rs Outdated Show resolved Hide resolved
primitives/shared/src/commitment/mod.rs Outdated Show resolved Hide resolved
th7nder
th7nder requested changes Oct 5, 2024
View reviewed changes
primitives/shared/src/piece.rs Outdated Show resolved Hide resolved
@cernicc cernicc marked this pull request as ready for review October 7, 2024 14:04
@jmg-duarte jmg-duarte mentioned this pull request Oct 7, 2024
Closed
jmg-duarte
jmg-duarte reviewed Oct 7, 2024
View reviewed changes
primitives/shared/Cargo.toml Outdated Show resolved Hide resolved
primitives/shared/src/piece.rs Outdated Show resolved Hide resolved
primitives/shared/src/piece.rs Outdated Show resolved Hide resolved
primitives/shared/Cargo.toml Outdated Show resolved Hide resolved
primitives/shared/src/commitment/zero.rs Outdated Show resolved Hide resolved
primitives/shared/src/commitment/mod.rs Outdated Show resolved Hide resolved
primitives/proofs/src/types.rs Show resolved Hide resolved
pallets/market/src/commd.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/src/commands/utils/mod.rs Outdated Show resolved Hide resolved
cli/polka-storage-provider/src/commands/utils/mod.rs Outdated Show resolved Hide resolved
@th7nder th7nder mentioned this pull request Oct 8, 2024
Closed
38 tasks
@th7nder th7nder mentioned this pull request Oct 8, 2024
Merged
8 tasks
@cernicc cernicc added the ready for review Review is needed label Oct 9, 2024
@cernicc cernicc added ready for review Review is needed and removed ready for review Review is needed labels Oct 9, 2024
th7nder
th7nder previously approved these changes Oct 9, 2024
View reviewed changes
pallets/market/src/mock.rs Outdated Show resolved Hide resolved
pallets/market/src/commd.rs Outdated Show resolved Hide resolved
jmg-duarte
jmg-duarte reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docs need improvement.

It's hard to pick them up without the context that you have and we should improve upon that since the final client is a community after all.

I've left some comments on some interfaces too

jmg-duarte
jmg-duarte approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job ❤️

primitives/commitment/src/commd.rs Show resolved Hide resolved
@jmg-duarte jmg-duarte enabled auto-merge (squash) October 9, 2024 12:49
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Oct 9, 2024
@jmg-duarte jmg-duarte merged commit 7541a46 into develop Oct 9, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the feat'92/compute_commd branch October 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@th7nder th7nder th7nder approved these changes

@aidan46 aidan46 Awaiting requested review from aidan46

@neutrinoks neutrinoks Awaiting requested review from neutrinoks

Assignees

@cernicc cernicc

Labels
ready for review Review is needed
Projects
None yet
Milestone
Phase 2
Development

Successfully merging this pull request may close these issues.

Market Pallet: port compute_commd
4 participants
@cernicc @th7nder @jmg-duarte @neutrinoks