-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pallet-proofs): verify PoSt #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
force-pushed
the
feat/439/verify-post-onchain
branch
3 times, most recently
from
October 21, 2024 13:05
3ceff66
to
9c884d4
Compare
jmg-duarte
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, but would appreciate some docs on this API. I know there's little to go off of from FC, but let's try 🥹
aidan46
reviewed
Oct 21, 2024
jmg-duarte
reviewed
Oct 22, 2024
th7nder
force-pushed
the
feat/439/verify-post-onchain
branch
from
October 22, 2024 11:33
ab84e3d
to
05a3732
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Oct 22, 2024
th7nder
force-pushed
the
feat/439/verify-post-onchain
branch
from
October 22, 2024 12:28
a926ff9
to
aaacac6
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Oct 22, 2024
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Oct 22, 2024
jmg-duarte
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ Komrad
aidan46
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces PoSt Verification on-chain, so it can be called later via
ProofVerification
trait bypallet-storage-provider
.Fixes #439.
Important points for reviewers
This is a showcase with test running in mocks.
This should be integrated later with Storage Provider Pallet #449.
Checklist
verify_submit_windowed_post
withpallet-proofs
verify PoSt #449