Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sp): Add batch events #612

Merged
merged 5 commits into from
Nov 27, 2024
Merged

feat(sp): Add batch events #612

merged 5 commits into from
Nov 27, 2024

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Nov 26, 2024

Description

This PR adds batch events in the SP pallet where applicable.

check_deadlines - This hook previously emitted an event for every faulty partition for every storage provider. It has been refactored to be a single event, PartitionsFaulty for every storage provider, collecting the faulty partition data along the way.
check_precommited_sectors - This hook previously emitted an event for every sector slashed for every storage provider. It has been refactored to be a single event, SectorsSlashed, for every storage provider, collection slashing data along the way.

The tests, documentation, and CLI have been updated to reflect this change.
The SCALE file with the metadata has been updated after this change.

@aidan46 aidan46 marked this pull request as ready for review November 26, 2024 06:16
@aidan46 aidan46 self-assigned this Nov 26, 2024
@aidan46 aidan46 added enhancement New feature or request ready for review Review is needed pallet-storage-provider Relates to the Storage Provider Pallet labels Nov 26, 2024
@aidan46 aidan46 added this to the Phase 3 milestone Nov 26, 2024
@aidan46 aidan46 linked an issue Nov 26, 2024 that may be closed by this pull request
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Nov 26, 2024
@aidan46 aidan46 force-pushed the 597-batch-extrinsic-calls branch from 5e1a404 to 3de75f7 Compare November 26, 2024 06:41
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Nov 26, 2024
@aidan46 aidan46 requested a review from a team November 26, 2024 09:19
@aidan46 aidan46 force-pushed the 597-batch-extrinsic-calls branch from 3de75f7 to f463b0e Compare November 26, 2024 09:20
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Nov 26, 2024
docs/src/architecture/pallets/storage-provider.md Outdated Show resolved Hide resolved
pallets/storage-provider/src/lib.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/lib.rs Show resolved Hide resolved
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Nov 27, 2024
@aidan46 aidan46 requested review from a team and th7nder November 27, 2024 05:36
@cernicc cernicc merged commit 2dda978 into develop Nov 27, 2024
5 checks passed
@cernicc cernicc deleted the 597-batch-extrinsic-calls branch November 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pallet-storage-provider Relates to the Storage Provider Pallet ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch extrinsic events if possible
4 participants