-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sp): Add batch events #612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan46
added
enhancement
New feature or request
ready for review
Review is needed
pallet-storage-provider
Relates to the Storage Provider Pallet
labels
Nov 26, 2024
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Nov 26, 2024
aidan46
force-pushed
the
597-batch-extrinsic-calls
branch
from
November 26, 2024 06:41
5e1a404
to
3de75f7
Compare
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Nov 26, 2024
aidan46
force-pushed
the
597-batch-extrinsic-calls
branch
from
November 26, 2024 09:20
3de75f7
to
f463b0e
Compare
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Nov 26, 2024
jmg-duarte
reviewed
Nov 26, 2024
th7nder
requested changes
Nov 26, 2024
Co-authored-by: Konrad Stepniak <konrad@eiger.co>
aidan46
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Nov 27, 2024
th7nder
approved these changes
Nov 27, 2024
cernicc
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
pallet-storage-provider
Relates to the Storage Provider Pallet
ready for review
Review is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds batch events in the SP pallet where applicable.
check_deadlines
- This hook previously emitted an event for every faulty partition for every storage provider. It has been refactored to be a single event,PartitionsFaulty
for every storage provider, collecting the faulty partition data along the way.check_precommited_sectors
- This hook previously emitted an event for every sector slashed for every storage provider. It has been refactored to be a single event,SectorsSlashed
, for every storage provider, collection slashing data along the way.The tests, documentation, and CLI have been updated to reflect this change.
The SCALE file with the metadata has been updated after this change.