Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: libp2p resolver rfc #629

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Dec 9, 2024

Description

This PR adds an RFC for the libp2p Peer ID to multiaddr resolver. This application will be used by clients to find the multiaddr associated with a Peer ID of a deal to fetch the file from the storage provider (using the polka-fetch component) I followed the guidelines described in rfc7322.

A follow-up PR will be created for the scraper that collects on-chain information about deals (both historical and current).

@aidan46 aidan46 added ready for review Review is needed rfc Request for Comments (RFC) labels Dec 9, 2024
@aidan46 aidan46 added this to the Phase 3 milestone Dec 9, 2024
@aidan46 aidan46 self-assigned this Dec 9, 2024
@aidan46 aidan46 linked an issue Dec 9, 2024 that may be closed by this pull request
@aidan46 aidan46 changed the title rfc: Add RFC for libp2p resolver docs: Add RFC for libp2p resolver Dec 9, 2024
@aidan46 aidan46 requested a review from a team December 9, 2024 09:23
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte changed the title docs: Add RFC for libp2p resolver docs: libp2p resolver rfc Dec 10, 2024
@jmg-duarte
Copy link
Collaborator

Should this RFC discuss Kademlia too?

@aidan46
Copy link
Contributor Author

aidan46 commented Dec 16, 2024

Should this RFC discuss Kademlia too?

We talked about moving forward with the rendezvous protocol. If we notice that the rendezvous protocol does not scale well we can move to Kademlia after creating an RFC for the upgrade.

jmg-duarte
jmg-duarte previously approved these changes Dec 16, 2024
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 16, 2024
@th7nder th7nder enabled auto-merge (squash) December 17, 2024 12:22
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Dec 17, 2024
@th7nder th7nder merged commit 27c9f38 into develop Dec 17, 2024
5 checks passed
@th7nder th7nder deleted the rfc/libp2p-peer-id-to-multiadd-resolver branch December 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed rfc Request for Comments (RFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libp2p Peer ID to multiaddr resolver RFC
3 participants