Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(randomness): use BABE's AuthorVRF as a randomness source #633

Merged
merged 6 commits into from
Dec 17, 2024
Merged

feat(randomness): use BABE's AuthorVRF as a randomness source #633

merged 6 commits into from
Dec 17, 2024

Conversation

jmg-duarte
Copy link
Collaborator

@jmg-duarte jmg-duarte commented Dec 12, 2024 •
edited
Loading

Description

Rewrites pallet-randomness to use BABE's AuthorVRF as a partial randomness source.

When running random(subject) it will pick up the latest AuthorVRF randomness value and hash it along with the subject.

Closes #458

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@jmg-duarte jmg-duarte self-assigned this Dec 12, 2024
@jmg-duarte jmg-duarte changed the title docs: randomness research rfc feat(randomness): use BABE's AuthorVRF as a randomness source Dec 13, 2024
@jmg-duarte jmg-duarte marked this pull request as ready for review December 13, 2024 12:09
@jmg-duarte jmg-duarte added the ready for review Review is needed label Dec 13, 2024
@jmg-duarte jmg-duarte enabled auto-merge (squash) December 13, 2024 12:09
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 13, 2024
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Dec 13, 2024
cernicc
cernicc approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 17, 2024
@jmg-duarte jmg-duarte merged commit c8d7542 into develop Dec 17, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the feat/randomness branch December 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidan46 aidan46 aidan46 left review comments

@th7nder th7nder th7nder approved these changes

@cernicc cernicc cernicc approved these changes

Assignees

@jmg-duarte jmg-duarte

Labels
ready for review Review is needed
Projects
None yet
Milestone
Phase 3
Development

Successfully merging this pull request may close these issues.

Substrate: Use secure randomness
4 participants
@jmg-duarte @cernicc @th7nder @aidan46