Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cancellation handling in proving #638

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Dec 13, 2024

Description

While testing I couldn't kill the storage provider cause it was indifferent to my requests.
I added cancellation token handling where it made sense.

Number(1) }))
2024-12-13T15:33:39.759387Z  INFO prove_commit{sector_number=SectorNumber(1)}: polka_storage_provider_server::pipeline: Starting prove commit
2024-12-13T15:33:39.759945Z  INFO prove_commit{sector_number=SectorNumber(1)}: polka_storage_provider_server::pipeline: Wait for block 52 to get randomness
^C2024-12-13T15:33:47.951085Z  INFO polka_storage_provider_server: SIGTERM received, shutting down...
2024-12-13T15:33:47.951133Z  INFO polka_storage_provider_server: sent shutdown signal
2024-12-13T15:33:47.951183Z  WARN polka_storage_provider_server::pipeline: submit_windowed_post for deadline 0 has been cancelled.
2024-12-13T15:33:47.951211Z  WARN polka_storage_provider_server::pipeline: submit_windowed_post for deadline 2 has been cancelled.
2024-12-13T15:33:47.951229Z  INFO start_pipeline: polka_storage_provider_server::pipeline: Pipeline has been stopped by the cancellation token...
2024-12-13T15:33:47.951238Z  WARN polka_storage_provider_server::pipeline: submit_windowed_post for deadline 1 has been cancelled.
2024-12-13T15:33:47.951314Z  WARN prove_commit{sector_number=SectorNumber(1)}: polka_storage_provider_server::pipeline: Cancelled while waiting to get randomness at block 52
2024-12-13T15:33:47.951358Z ERROR polka_storage_provider_server::pipeline: Failed ProveCommit for Sector: 1 err=Proving cancelled
[1]    88694 terminated  examples/start_sp.sh examples/test-data-big.txt

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • Have you tested this solution?

@th7nder th7nder added the bug Something isn't working label Dec 13, 2024
@th7nder th7nder added this to the Phase 3 milestone Dec 13, 2024
@th7nder th7nder self-assigned this Dec 13, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@th7nder th7nder merged commit 48893f3 into develop Dec 16, 2024
5 checks passed
@th7nder th7nder deleted the fix/no-ref/cancellations branch December 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants