Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storagext): allow extrinsics to be submitted in parallel #643

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix(storagext): allow extrinsics to be submitted in parallel #643

merged 3 commits into from
Dec 18, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Dec 18, 2024 •
edited
Loading

Description

Fixes #641.
Details in the documentation and in the rustdocs.
I did not implement the retry mechanism, cause I deem it not needed now.

This is a solution for paritytech/subxt#1886.

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@th7nder th7nder added the bug Something isn't working label Dec 18, 2024
@th7nder th7nder self-assigned this Dec 18, 2024
@th7nder th7nder added the ready for review Review is needed label Dec 18, 2024
jmg-duarte
jmg-duarte previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the biggest fan of the approach but if it works

storagext/lib/src/runtime/client.rs Outdated Show resolved Hide resolved
storagext/lib/src/runtime/client.rs Outdated Show resolved Hide resolved
cernicc
cernicc reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job catching and fixing this 💪 Left some comments.

storagext/lib/src/runtime/client.rs Show resolved Hide resolved
storagext/lib/src/runtime/client.rs Outdated Show resolved Hide resolved
storagext/lib/src/runtime/client.rs Outdated Show resolved Hide resolved
storagext/lib/src/runtime/client.rs Outdated Show resolved Hide resolved
storagext/lib/src/runtime/client.rs Outdated Show resolved Hide resolved
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Dec 18, 2024
@th7nder th7nder mentioned this pull request Dec 18, 2024
Open
27 tasks
@jmg-duarte jmg-duarte enabled auto-merge (squash) December 18, 2024 14:59
@jmg-duarte jmg-duarte merged commit 4d89958 into develop Dec 18, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the fix/522/nonces branch December 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@cernicc cernicc cernicc approved these changes

@aidan46 aidan46 Awaiting requested review from aidan46

Assignees

@th7nder th7nder

Labels
bug Something isn't working ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle multiple concurrent transactions in subxt
3 participants
@th7nder @cernicc @jmg-duarte