Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pallet-randomness): bring back the getter API #646

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

jmg-duarte
Copy link
Collaborator

Description

I removed the coupling in the previous PR, that was a mistake.
Re-added to fix randomness, I'm not super API with the API but code that works > pretty code that doesn't

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?

@jmg-duarte jmg-duarte added this to the Phase 3 milestone Dec 18, 2024
@jmg-duarte jmg-duarte self-assigned this Dec 18, 2024
@jmg-duarte jmg-duarte added the ready for review Review is needed label Dec 18, 2024
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 18, 2024
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 19, 2024
th7nder
th7nder previously approved these changes Dec 19, 2024
storage-provider/server/Cargo.toml Outdated Show resolved Hide resolved
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 19, 2024
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Dec 19, 2024
@jmg-duarte jmg-duarte enabled auto-merge (squash) December 19, 2024 13:57
@jmg-duarte jmg-duarte merged commit ff84bc1 into develop Dec 19, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the fix/randomness branch December 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants