Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Implement docstrings for UDL #12

Closed

Conversation

arg0d
Copy link

@arg0d arg0d commented Oct 26, 2023

Docstrings are declared in .udl file by prefixing a line with three slashes ///. Docstrings can be placed basically anywhere - functions, objects, methods, constructors, callbacks, etc.. A docstring placed in a wrong place will generate UDL parser error.

@arg0d
Copy link
Author

arg0d commented Oct 26, 2023

This PR was created for new-upstream from yesterday, but today it seems like the branch is gone, and main is knackered with merge conflicts, so I can't rebase on main.

@MeerKatDev
Copy link
Member

MeerKatDev commented Oct 26, 2023

Hi, sorry @arg0d, I just finished merging - it seems the PR is rebased to main. Is the PR ok to be reviewed?

@arg0d
Copy link
Author

arg0d commented Oct 26, 2023

Which branch should this be rebased on?

@arg0d
Copy link
Author

arg0d commented Oct 26, 2023

What I meant before is, this repo has conflicts comitted into the main branch.

@MeerKatDev
Copy link
Member

@arg0d Yes, I'm fixing them. Sorry for the inconvenient.

@MeerKatDev
Copy link
Member

@arg0d you should be good to go

@MeerKatDev MeerKatDev force-pushed the main branch 2 times, most recently from 72ad9fa to a26981f Compare October 26, 2023 13:42
@arg0d arg0d force-pushed the kristupas/docstrings-eigerco branch 2 times, most recently from ce1d141 to 6b19927 Compare October 26, 2023 14:20
@arg0d
Copy link
Author

arg0d commented Oct 26, 2023

I think this is ready for review

Docstrings are declared in .udl file by prefixing a line with three
slashes ///. Docstrings can be placed basically anywhere - functions,
objects, methods, constructors, callbacks, etc.. A docstring placed in
a wrong place will generate UDL parser error.
@arg0d arg0d force-pushed the kristupas/docstrings-eigerco branch from 6b19927 to 7dbbb5f Compare October 26, 2023 14:26
@arg0d arg0d closed this Sep 13, 2024
@arg0d arg0d deleted the kristupas/docstrings-eigerco branch September 13, 2024 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants