Skip to content

Actor Registration protobuf updated #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Actor Registration protobuf updated #5

merged 1 commit into from
Oct 28, 2022

Conversation

venkatesh-sp
Copy link
Contributor

No description provided.

logging.error("Shit %s", e.__cause__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it best practice to have a newline of every line?

Copy link
Member

@sleipnir sleipnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this PR but then I will update the proto files because they have already changed from yesterday to today with Elias' PR in the proxy

logging.error("Shit %s", e.__cause__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be deleted

@sleipnir sleipnir merged commit 87f7ebf into main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants