-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .mapping(dep) shorthand method to resolve mapped bare imports directly #112
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will continue to loop through this.maps even after found a match. You could return the result immediately - unless we can see a scenario where the same dependency exists in multiple maps and we have defined that the last import map takes presedence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty interesting point when I think about it.
There might be multiple import maps and two maps (or more) can contain the same identifier but with different targets. Then the question is which one wins. In our build tool plugins the last occurrence wins at the moment (in the plugins the algorithm is a little bit different though, but the result is the same). So, should first or last occurrence win here?
The answer is probably more complex. Import Maps do have a feature to deal with this which is defined under https://github.com/WICG/import-maps#multiple-versions-of-the-same-module. Currently our build tool plugins have a little bit of a naive implementation of the Import Map spec and we do not take scoping into account. We should have full Import Map support though (aka also supporting scoping) and we have an experimental implementation in the ESBuild plugin: eik-lib/esbuild-plugin#71
Ideally this method should actually apply full Import Map parsing and adhere to the algorithm in the spec to decide what to return.
But to be practical here: I think this is fine since this aligns with whats currently happening in the build tools. But, we should do an effort to get support for the whole Import Map spec and in this process get this method to do so too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left the code alone and simply updated the docs for now.