Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI dark theme #293

Closed
eikek opened this issue Sep 29, 2020 · 3 comments · Fixed by #634
Closed

UI dark theme #293

eikek opened this issue Sep 29, 2020 · 3 comments · Fixed by #634
Labels
web-ui-1 expired

Comments

@eikek
Copy link
Owner

eikek commented Sep 29, 2020

From #289

@eikek eikek added the web-ui-1 expired label Jan 5, 2021
@eikek
Copy link
Owner Author

eikek commented Jan 31, 2021

I looked into this a bit. Turns out that there is an issue at fomantic-ui for this (fomantic/Fomantic-UI#1424). But reading through this and many related issues it doesn't seem likely that this comes in a near future. I also tried to look into fomantic in order to maybe provide a dark theme myself, but I was overwhelmed by the huge amount of things to change…. It is way too much work to be done in this context.

I also have thoughts replacing fomantic by something else for other reasons. While it is great in general and provides many useful things, it is always a hassle when deviating from anticipated features. Then custom css is necassary. There is already a lot of utility classes for spacing etc. You then need to look into existing css from fomantic to find out what you can change and provide a more specific selector etc. It's not fun.

I had a look at tailwindcss which sounded very promising. I like its approach very much and I think it is much better suited for projects like docspell. Experimenting with it only confirms this impression. So my plan is now to replace the webui completely. This is also a good opportunity to do some refactoring that I had in mind anyways :-). This is some work obviously, but it's worth it for a more reusable css. With tailwind we can provide dark themes for just the components used in docspell.

@eikek eikek added this to the Docspell 0.20.0 milestone Feb 3, 2021
@eikek
Copy link
Owner Author

eikek commented Feb 3, 2021

There is now a "new" webui on the way in the new-webui branch. This integrates tailwindcss and adds darkmode, because all markup + css has to be rewritten anyways. This might take a while :-) the next version gets a preview, the current ui is not removed.

@eikek eikek mentioned this issue Feb 14, 2021
@eikek
Copy link
Owner Author

eikek commented Feb 14, 2021

The new ui is merged soon. For the next release, both uis are included so one can still go back to the old ui if things don't work. The new ui is the default, please have a look and file issues for things that don't work. Thanks! Edit: only if you run the master/snapshot version :).

Switching the ui requires to send a request header, Docspell-Ui: 1, this can be easily done using a browser addon, for example this (firefox) / this (chromium). Using this addon, you can switch between uis via a click and then reloading the page (do a "hard reload", to clear browser caches).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-ui-1 expired
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant