-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme support #140
Comments
I had the same issue and coded a working solution. Works with one CSS file and basic JavaScript functions for the switch and color settings recall on load. Here is the GitHub Demo page : https://dorson.github.io/CSS-Dark-Mode-and-color-switch/ Feel free to copy, fork, adopt, port, etc... |
Thank you for your input @Just-Insane – I can really understand this wish to have a dark theme. I'm using for the time being the dark-reader browser extension. It is obviously not optimal, but works good enough (for a lot of pages). I just found https://semantic-ui-forest.com/themes – maybe it is enough to simply refer to a different css. @Dorson thank you! I'm going to take a look and see if it can help here. I'm using pre-build semantic-ui css framework, so I'm not sure if I can define color sets without including a customized semantic-ui build. |
These are both awesome solutions! @eikek i saw those too, but I wasn’t sure where the default css for semantic-hi was called in the source when I was looking at it (changing the sharry.css file does not work). |
@Just-Insane the semantic css comes in here. I think (not verified), if you put in here a url to a different style, it should work…. Requires recompile and everything, obviously. |
Oh sorry, you are right. It is line 123. |
That seems to miss the standard semanticui styles. You could try adding this additional to the standard style… I have no clue, really. |
It looks like a dark theme would have to be created manually... this is the closest I've found, but it's missing a lot of the includes (they 404). |
Ah that's too bad, thanks for trying out! Then I guess, this is quite some work. I don't think I can do it in the near future (PRs are welcome, of course). For the far away future :) I'm thinking to maybe migrate the ui to bulma-css, as it seems to be a better fit (no js involved and there are elm packages). If that happens, then I'm going to provide light and dark themes. |
Update for this: I moved my other project from fomantic to tailwind and it was a very pleasant experience. I'm now thinking about doing the same for sharry. It's also easier to maintain both projects then:-). (for context see eikek/docspell#293.) |
It would be nice to have a dark theme or user-selectable theme, or even a night-mode toggle available in the UI.
The text was updated successfully, but these errors were encountered: