Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Consumable: blacklisting products using user's settings #19

Merged
merged 5 commits into from
Feb 5, 2020

Conversation

tomMoulard
Copy link
Member

This pull request add a way to blacklist some products to a user using it's settings

@pull-assistant
Copy link

pull-assistant bot commented Feb 5, 2020

Score: 0.80

Best reviewed: commit by commit


Optimal code review plan (1 warning)

     swagger: small prettier fixes

consumable: adding a filter using user settings

misc/structures/structures.go 49% changes removed in consumable: checking...

     consumable: checking if the consumable is boycotted(and tests)

     consumable_test: adding more edge cases to test boycott function

     consumable: fixing typo in doc

Powered by Pull Assistant. Last update 0de2121 ... 3d415fb. Read the comment docs.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsBio` to filter consumables

// TODO: Create a function `IsBio` to filter consumables
return true
}
// IsVegan return true is the consumable is Vegan
func IsVegan(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsVegan` to filter consumables

// TODO: Create a function `IsVegan` to filter consumables
return true
}
// IsHalal return true is the consumable is Halal
func IsHalal(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsHalal` to filter consumables

// TODO: Create a function `IsHalal` to filter consumables
return true
}
// IsCasher return true is the consumable is Casher
func IsCasher(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsCasher` to filter consumables

// TODO: Create a function `IsCasher` to filter consumables
return true
}
// ContainSodium return true is the consumable contain salt
func ContainSodium(c structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `ContainEgg` to filter consumables

// TODO: Create a function `ContainEgg` to filter consumables
return true
}
// ContainPenut return true is the consumable contain penut
func ContainPenut(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `ContainPenut` to filter consumables

// TODO: Create a function `ContainPenut` to filter consumables
return true
}
// ContainCrustace return true is the consumable contain crustace
func ContainCrustace(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `ContainCrustace` to filter consumables

// TODO: Create a function `ContainCrustace` to filter consumables
return true
}
// IsGlutenFree return true is the consumable is guten free
func IsGlutenFree(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsGlutenFree` to filter consumables

// TODO: Create a function `IsGlutenFree` to filter consumables
return true
}
// ForDiabetique return true is the consumable is suited for diabetique
func ForDiabetic(c structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Implement an array merging system

// TODO: Implement an array merging system
}
return i1
}


This comment was generated by todo based on a TODO comment in baa9163 in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsBio` to filter consumables

// TODO: Create a function `IsBio` to filter consumables
return true
}
// IsVegan return true is the consumable is Vegan
func IsVegan(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsVegan` to filter consumables

// TODO: Create a function `IsVegan` to filter consumables
return true
}
// IsHalal return true is the consumable is Halal
func IsHalal(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsHalal` to filter consumables

// TODO: Create a function `IsHalal` to filter consumables
return true
}
// IsCasher return true is the consumable is Casher
func IsCasher(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsCasher` to filter consumables

// TODO: Create a function `IsCasher` to filter consumables
return true
}
// ContainSodium return true is the consumable contain salt
func ContainSodium(c structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `ContainEgg` to filter consumables

// TODO: Create a function `ContainEgg` to filter consumables
return true
}
// ContainPenut return true is the consumable contain penut
func ContainPenut(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `ContainPenut` to filter consumables

// TODO: Create a function `ContainPenut` to filter consumables
return true
}
// ContainCrustace return true is the consumable contain crustace
func ContainCrustace(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `ContainCrustace` to filter consumables

// TODO: Create a function `ContainCrustace` to filter consumables
return true
}
// IsGlutenFree return true is the consumable is guten free
func IsGlutenFree(structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@todo
Copy link

todo bot commented Feb 5, 2020

Create a function `IsGlutenFree` to filter consumables

// TODO: Create a function `IsGlutenFree` to filter consumables
return true
}
// ForDiabetic return true is the consumable is suited for diabetique
func ForDiabetic(c structures.Consumable) bool {


This comment was generated by todo based on a TODO comment in 3d415fb in #19. cc @eiko-team.

@codecov-io
Copy link

Codecov Report

Merging #19 into master will decrease coverage by 2.59%.
The diff coverage is 54.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #19     +/-   ##
=========================================
- Coverage   83.89%   81.29%   -2.6%     
=========================================
  Files          14       15      +1     
  Lines         478      524     +46     
=========================================
+ Hits          401      426     +25     
- Misses         64       84     +20     
- Partials       13       14      +1
Impacted Files Coverage Δ
misc/consumable/consumable.go 20% <20%> (ø)
misc/structures/structures.go 66.66% <95.23%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662db95...3d415fb. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants