feat: implement Delete endpoint tests

Implements basic Delete endpoint tests, identical to the Get endpoint
tests.

README.md

@@ -178,4 +178,14 @@ Suites
 | one by one         | Searching resource one by one should eventually return all resources.          | Generated only if all are true: <ul><li>resource has a parent</li><li>has Search method</li><li>resource has a parent</li></ul>                           |
 | deleted            | Method should not return deleted resources.                                    | Generated only if all are true: <ul><li>resource has a parent</li><li>has Search method</li><li>has Delete method</li><li>resource has a parent</li></ul> |
 
+### Delete
+
+| Name           | Description                                                                                | Only if                                                             |
+|----------------|--------------------------------------------------------------------------------------------|---------------------------------------------------------------------|
+| missing name   | Method should fail with InvalidArgument if no name is provided.                            | Generated only if all are true: <ul><li>has Delete method</li></ul> |
+| invalid name   | Method should fail with InvalidArgument if the provided name is not valid.                 | Generated only if all are true: <ul><li>has Delete method</li></ul> |
+| exists         | Resource should be deleted without errors if it exists.                                    | Generated only if all are true: <ul><li>has Delete method</li></ul> |
+| not found      | Method should fail with NotFound if the resource does not exist.                           | Generated only if all are true: <ul><li>has Delete method</li></ul> |
+| only wildcards | Method should fail with InvalidArgument if the provided name only contains wildcards ('-') | Generated only if all are true: <ul><li>has Delete method</li></ul> |
+
 <!-- END suites -->

internal/aiptest/deletion/delete.go

@@ -0,0 +1,18 @@
+package deletion
+
+import (
+	"github.com/einride/protoc-gen-go-aip-test/internal/suite"
+)
+
+// Suite of Delete tests.
+//nolint: gochecknoglobals
+var Suite = suite.Suite{
+	Name: "Delete",
+	Tests: []suite.Test{
+		missingName,
+		invalidName,
+		exists,
+		notFound,
+		wildcardName,
+	},
+}

internal/aiptest/deletion/exists.go

@@ -0,0 +1,39 @@
+package deletion
+
+import (
+	"github.com/einride/protoc-gen-go-aip-test/internal/ident"
+	"github.com/einride/protoc-gen-go-aip-test/internal/onlyif"
+	"github.com/einride/protoc-gen-go-aip-test/internal/suite"
+	"github.com/einride/protoc-gen-go-aip-test/internal/util"
+	"go.einride.tech/aip/reflect/aipreflect"
+	"google.golang.org/protobuf/compiler/protogen"
+)
+
+//nolint: gochecknoglobals
+var exists = suite.Test{
+	Name: "exists",
+	Doc: []string{
+		"Resource should be deleted without errors if it exists.",
+	},
+
+	OnlyIf: suite.OnlyIfs(
+		onlyif.HasMethod(aipreflect.MethodTypeDelete),
+	),
+	Generate: func(f *protogen.GeneratedFile, scope suite.Scope) error {
+		deleteMethod, _ := util.StandardMethod(scope.Service, scope.Resource, aipreflect.MethodTypeDelete)
+
+		if util.HasParent(scope.Resource) {
+			f.P("parent := ", ident.FixtureNextParent, "(t, false)")
+			f.P("created := fx.create(t, parent)")
+		} else {
+			f.P("created := fx.create(t)")
+		}
+		util.MethodDelete{
+			Resource: scope.Resource,
+			Method:   deleteMethod,
+			Name:     "created.Name",
+		}.Generate(f, "_", "err", ":=")
+		f.P(ident.AssertNilError, "(t, err)")
+		return nil
+	},
+}

internal/aiptest/deletion/name_invalid.go

@@ -0,0 +1,35 @@
+package deletion
+
+import (
+	"strconv"
+
+	"github.com/einride/protoc-gen-go-aip-test/internal/ident"
+	"github.com/einride/protoc-gen-go-aip-test/internal/onlyif"
+	"github.com/einride/protoc-gen-go-aip-test/internal/suite"
+	"github.com/einride/protoc-gen-go-aip-test/internal/util"
+	"go.einride.tech/aip/reflect/aipreflect"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/protobuf/compiler/protogen"
+)
+
+//nolint: gochecknoglobals
+var invalidName = suite.Test{
+	Name: "invalid name",
+	Doc: []string{
+		"Method should fail with InvalidArgument if the provided name is not valid.",
+	},
+
+	OnlyIf: suite.OnlyIfs(
+		onlyif.HasMethod(aipreflect.MethodTypeDelete),
+	),
+	Generate: func(f *protogen.GeneratedFile, scope suite.Scope) error {
+		deleteMethod, _ := util.StandardMethod(scope.Service, scope.Resource, aipreflect.MethodTypeDelete)
+		util.MethodDelete{
+			Resource: scope.Resource,
+			Method:   deleteMethod,
+			Name:     strconv.Quote("invalid resource name"),
+		}.Generate(f, "_", "err", ":=")
+		f.P(ident.AssertEqual, "(t, ", ident.Codes(codes.InvalidArgument), ",", ident.StatusCode, "(err), err)")
+		return nil
+	},
+}

internal/aiptest/deletion/name_missing.go

@@ -0,0 +1,35 @@
+package deletion
+
+import (
+	"strconv"
+
+	"github.com/einride/protoc-gen-go-aip-test/internal/ident"
+	"github.com/einride/protoc-gen-go-aip-test/internal/onlyif"
+	"github.com/einride/protoc-gen-go-aip-test/internal/suite"
+	"github.com/einride/protoc-gen-go-aip-test/internal/util"
+	"go.einride.tech/aip/reflect/aipreflect"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/protobuf/compiler/protogen"
+)
+
+//nolint: gochecknoglobals
+var missingName = suite.Test{
+	Name: "missing name",
+	Doc: []string{
+		"Method should fail with InvalidArgument if no name is provided.",
+	},
+
+	OnlyIf: suite.OnlyIfs(
+		onlyif.HasMethod(aipreflect.MethodTypeDelete),
+	),
+	Generate: func(f *protogen.GeneratedFile, scope suite.Scope) error {
+		deleteMethod, _ := util.StandardMethod(scope.Service, scope.Resource, aipreflect.MethodTypeDelete)
+		util.MethodDelete{
+			Resource: scope.Resource,
+			Method:   deleteMethod,
+			Name:     strconv.Quote(""),
+		}.Generate(f, "_", "err", ":=")
+		f.P(ident.AssertEqual, "(t, ", ident.Codes(codes.InvalidArgument), ",", ident.StatusCode, "(err), err)")
+		return nil
+	},
+}

internal/aiptest/deletion/not_found.go

@@ -0,0 +1,41 @@
+package deletion
+
+import (
+	"github.com/einride/protoc-gen-go-aip-test/internal/ident"
+	"github.com/einride/protoc-gen-go-aip-test/internal/onlyif"
+	"github.com/einride/protoc-gen-go-aip-test/internal/suite"
+	"github.com/einride/protoc-gen-go-aip-test/internal/util"
+	"go.einride.tech/aip/reflect/aipreflect"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/protobuf/compiler/protogen"
+)
+
+//nolint: gochecknoglobals
+var notFound = suite.Test{
+	Name: "not found",
+	Doc: []string{
+		"Method should fail with NotFound if the resource does not exist.",
+	},
+
+	OnlyIf: suite.OnlyIfs(
+		onlyif.HasMethod(aipreflect.MethodTypeDelete),
+	),
+	Generate: func(f *protogen.GeneratedFile, scope suite.Scope) error {
+		deleteMethod, _ := util.StandardMethod(scope.Service, scope.Resource, aipreflect.MethodTypeDelete)
+
+		if util.HasParent(scope.Resource) {
+			f.P("parent := ", ident.FixtureNextParent, "(t, false)")
+			f.P("created := fx.create(t, parent)")
+		} else {
+			f.P("created := fx.create(t)")
+		}
+		util.MethodDelete{
+			Resource: scope.Resource,
+			Method:   deleteMethod,
+			// appending to the resource name ensures it is valid
+			Name: "created.Name + \"notfound\"",
+		}.Generate(f, "_", "err", ":=")
+		f.P(ident.AssertEqual, "(t, ", ident.Codes(codes.NotFound), ",", ident.StatusCode, "(err), err)")
+		return nil
+	},
+}

internal/aiptest/deletion/wildcard.go

@@ -0,0 +1,35 @@
+package deletion
+
+import (
+	"strconv"
+
+	"github.com/einride/protoc-gen-go-aip-test/internal/ident"
+	"github.com/einride/protoc-gen-go-aip-test/internal/onlyif"
+	"github.com/einride/protoc-gen-go-aip-test/internal/suite"
+	"github.com/einride/protoc-gen-go-aip-test/internal/util"
+	"go.einride.tech/aip/reflect/aipreflect"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/protobuf/compiler/protogen"
+)
+
+//nolint: gochecknoglobals
+var wildcardName = suite.Test{
+	Name: "only wildcards",
+	Doc: []string{
+		"Method should fail with InvalidArgument if the provided name only contains wildcards ('-')",
+	},
+
+	OnlyIf: suite.OnlyIfs(
+		onlyif.HasMethod(aipreflect.MethodTypeDelete),
+	),
+	Generate: func(f *protogen.GeneratedFile, scope suite.Scope) error {
+		deleteMethod, _ := util.StandardMethod(scope.Service, scope.Resource, aipreflect.MethodTypeDelete)
+		util.MethodDelete{
+			Resource: scope.Resource,
+			Method:   deleteMethod,
+			Name:     strconv.Quote(util.WildcardResourceName(scope.Resource)),
+		}.Generate(f, "_", "err", ":=")
+		f.P(ident.AssertEqual, "(t, ", ident.Codes(codes.InvalidArgument), ",", ident.StatusCode, "(err), err)")
+		return nil
+	},
+}

internal/aiptest/suites.go

@@ -3,6 +3,7 @@ package aiptest
 import (
 	"github.com/einride/protoc-gen-go-aip-test/internal/aiptest/batchget"
 	"github.com/einride/protoc-gen-go-aip-test/internal/aiptest/create"
+	"github.com/einride/protoc-gen-go-aip-test/internal/aiptest/deletion"
 	"github.com/einride/protoc-gen-go-aip-test/internal/aiptest/get"
 	"github.com/einride/protoc-gen-go-aip-test/internal/aiptest/list"
 	"github.com/einride/protoc-gen-go-aip-test/internal/aiptest/search"
@@ -19,4 +20,5 @@ var Suites = []suite.Suite{
 	update.Suite,
 	list.Suite,
 	search.Suite,
+	deletion.Suite,
 }