bump deps 2024 #160
Merged
bump deps 2024 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
odsod
commented
Jul 8, 2024
odsod
commented
- chore: update CODEOWNERS
- feat: bump deps 2024
Moving over for ongoing maintenance in Platform Engineering.
alethenorio
reviewed
Jul 8, 2024
.sage/main.go
Outdated
| sg.SerialDeps(ctx, Proto.All, TypescriptLint) | ||
| sg.SerialDeps(ctx, GoModTidy, GitVerifyNoDiff) | ||
| return nil | ||
| } | ||
|
|
||
| func FormatYAML(ctx context.Context) error { | ||
| func FormatYaml(ctx context.Context) error { |
There was a problem hiding this comment.
YAML is an acronym. The general Go guideline is to make it uppercase.
There was a problem hiding this comment.
copy pasted this from the Sage example: https://github.com/einride/sage/blob/master/example/.sage/main.go#L72 - we typically break convention here to make the generated kebab-case always consistent
There was a problem hiding this comment.
The kebab case should be correctly generated (as noted by the fact the makefile target hasn't changed) so why do we want to break convention? Maybe we can instead fix the Sage target?
alethenorio
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.