Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback version update on api-linter #466

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

DavyJ0nes
Copy link

@DavyJ0nes DavyJ0nes commented Oct 3, 2023

Updates api-linter to version v1.56.1 as v.1.57.0 introduced a new
requirement for (google.api.field_behavior) = IDENTIFIER to be set on
the name field of a proto resource.

There is a conflict between buf lint and api-linter due to an update to
field_behaviour.proto. An issue has been opened buf as fix is on their side:
bufbuild/buf#2474

Updates api-linter to version v1.56.1 as v.1.57.0 introduced a new
requirement for (google.api.field_behavior) = IDENTIFIER to be set on
the name field of a proto resource.

There is a conflict between buf lint and api-linter due to an update to
field_behaviour.proto. An issue has been opened buf as fix is on their side:
bufbuild/buf#2474
@DavyJ0nes DavyJ0nes self-assigned this Oct 3, 2023
Copy link
Member

@radhus radhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kallekrantz hope this doesn't segfault for you 😅

@DavyJ0nes DavyJ0nes merged commit 5b4571a into master Oct 3, 2023
3 checks passed
@DavyJ0nes DavyJ0nes deleted the revert-api-linter-update branch October 3, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants