fix(cloud-spanner): stop emulator container with background context #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a background context with a 10s timeout when stopping the emulator. This makes sure the container is (at least attempted) stopped when e.g. pressing ctrl-c while running tests.
odsod
approved these changes
Oct 4, 2024
radhus
added a commit
that referenced
this pull request
Oct 31, 2024
Fixes a bug introduced in b1b5e7e (PR #594) where an empty context is used, which removes the logger. Could be done cleaner with Go >=1.21 as can be seen in a TODO comment. Before: ``` ❯ make go-test [sage] building binary and generating Makefiles... [go-test] running Go tests... [go-test] starting Cloud Spanner emulator... [go-test] running Cloud Spanner emulator on 0.0.0.0:44611 [sage] stopping down Cloud Spanner emulator... ``` After: ``` ❯ make go-test [sage] building binary and generating Makefiles... [go-test] running Go tests... [go-test] starting Cloud Spanner emulator... [go-test] running Cloud Spanner emulator on 0.0.0.0:46023 [go-test] stopping down Cloud Spanner emulator... ```
radhus
added a commit
that referenced
this pull request
Oct 31, 2024
Fixes a bug introduced in b1b5e7e (PR #594) where an empty context is used, which removes the logger. Could be done cleaner with Go >=1.21 as can be seen in a TODO comment. Before: ``` ❯ make go-test [sage] building binary and generating Makefiles... [go-test] running Go tests... [go-test] starting Cloud Spanner emulator... [go-test] running Cloud Spanner emulator on 0.0.0.0:44611 [sage] stopping down Cloud Spanner emulator... ``` After: ``` ❯ make go-test [sage] building binary and generating Makefiles... [go-test] running Go tests... [go-test] starting Cloud Spanner emulator... [go-test] running Cloud Spanner emulator on 0.0.0.0:46023 [go-test] stopping down Cloud Spanner emulator... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a background context with a 10s timeout when stopping the emulator.
This makes sure the container is (at least attempted) stopped when e.g. pressing ctrl-c while running tests.