feat(golangcilint): lint wire files #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wire is used a lot in our organization, but the linter is skipping all
wire.go files due to them having a mandatory build tag.
This includes the build tag when running the linter, to make sure
`wire.go` files are linted as well.
I would expect linter to break a lot of repos now, but likely with very
easy fixes. Example:
```
❯ make go-lint
[sage] building binary and generating Makefiles...
[go-lint] running...
[go-lint]
internal/app/server/wire.go:61: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
internal/app/server/wire.go:63: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
[ ... code ... ]
internal/app/server/wire.go:62: File is not `gofumpt`-ed with `-extra` (gofumpt)
[ ... code ... ]
internal/app/server/wire.go:47:11: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func Init(ctx context.Context, config *Config) (*App, func(), error) {
```
alethenorio
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire is used a lot in our organization, but the linter is skipping all
wire.gofiles due to them having a mandatory build tag.This includes the build tag when running the linter, to make sure
wire.gofiles are linted as well.I would expect linter to break a lot of repos now, but likely with very easy fixes. Example: